Regarding the two failed CI jobs:

1. Yes, technically the public API changes, but see my description above for why I believe this is not an issue here.
2. The failing lifecycle hook tests seem unrelated to this change(?)

presubmit

@kara The command you listed fails for me with like below. Nonetheless, I think I should have updated everything accordingly.

$ bazel run //tools/public_api_guard:forms_api.accept
INFO: Options provided by the client:
  Inherited 'common' options: --isatty=1 --terminal_columns=140
INFO: Reading rc options for 'run' from /home/ingo/repos/angular/.bazelrc:
  Inherited 'build' options: --strategy=AngularTemplateCompile=worker --strategy=TypeScriptCompile=standalone --symlink_prefix=dist/ --nowatchfs --incompatible_strict_action_env --experimental_ui --define=compile=legacy
ERROR: Unrecognized option: --incompatible_strict_action_env
error Command failed with exit code 2.

Hi @Airblader,

This change will most likely be breaking, so we can see if we can include it into one of the next major releases (v11). Could you please rebase this PR when you get a chance, so that I can run a new presubmit to estimate the effort that would be required to adapt g3 apps code to this change?

Thank you,
Andrew

@AndrewKushnir I've rebased it.

Thanks for the rebase @Airblader 👍 I've started g3 presubmit (+ global presubmit) to estimate the effort that'd be required to land this change.

@Airblader, thanks for updating the PR, it looks like a couple CI jobs are failing (lint and test). Could you please have a look at the failures and update the code? Thank you.

@AndrewKushnir Should be fixed now.

I had that, but the tests failed because they said it has to be like this.

@Airblader could you please try to apply the changes to the packages/forms/src/directives/control_value_accessor.ts file and run the following command after that (it should update the goldens/public-api/forms/forms.d.ts file, the .d.ts files are generated by the script):

yarn public-api:update

If there are failing tests after these changes, please let us know, we'll look into that.

Thank you.

@AndrewKushnir I updated it and ran the yarn command, which did not change the public-api to the same but instead retained readonly X[].

Edit: Now updating it manually in the public-api and re-running the yarn command to see if it will undo that again. I won't push that but will let you know here what happened.

Edit 2: Yeah, it undoes it and changes it back to readonly X[].

Presubmit + Global Presubmit.

Presubmit #2 + Global Presubmit #2.

Quick update:

• tests in Google's codebase went well (including Global run)
• there were no cases in Google's codebase that required a cleanup due to this change (no targets were broken)
• there are no migration planned for this change due to low probability of breakages due to this change
• this PR has all the necessary approvals now and I'm adding it to the merge queue

@Airblader thanks for contributing to Angular! 👍

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}